matt/uc_stripe
1
0
Fork 0
Code Issues 1 Pull Requests 2 Packages Projects Releases Wiki Activity

Add metadata in 7.x-3.x-dev #10

Open
mattbk wants to merge 16 commits from add-metadata-endracing-7.x-3.1 into 7.x-3.x-dev
pull from: add-metadata-endracing-7.x-3.1
merge into: matt:7.x-3.x-dev
Conversation 6 Commits 16 Files Changed 4 +37 -9
mattbk commented 2019-10-03 22:07:48 -05:00 (Migrated from github.com)
Copy Link

The commit history is going to be a mess, but maybe a decent patch can come out.

The commit history is going to be a mess, but maybe a decent patch can come out.
mattbk commented 2019-10-03 22:17:07 -05:00 (Migrated from github.com)
Copy Link

Okay, so I must have ripped out the UI for this.

Okay, so I must have ripped out the UI for this.
mattbk commented 2019-10-03 23:31:15 -05:00 (Migrated from github.com)
Copy Link

Wow, still failing to get the metadata into the Stripe payload somehow.

It gets into an array fine:
Screen Shot 2019-10-03 at 11 31 37 PM

But nothing comes out on the Stripe side.

Wow, still failing to get the metadata into the Stripe payload somehow. It gets into an array fine: <img width="347" alt="Screen Shot 2019-10-03 at 11 31 37 PM" src="https://user-images.githubusercontent.com/3729038/66181344-064f6600-e636-11e9-8e04-c84186972bdd.png"> But nothing comes out on the Stripe side.
mattbk commented 2019-10-03 23:50:10 -05:00 (Migrated from github.com)
Copy Link

Leaving this for now. Next up try to get something into description so at least I see my changes are having an effect.

Testing on NPA.

Leaving this for now. Next up try to get something into `description` so at least I see my changes are having an effect. Testing on NPA.
mattbk commented 2019-10-04 15:04:29 -05:00 (Migrated from github.com)
Copy Link

I wasn't building the metadata in both places it was potentially needed.

Next up is to follow the checkboxes.

I wasn't building the metadata in both places it was potentially needed. Next up is to follow the checkboxes.
mattbk commented 2019-10-04 20:57:46 -05:00 (Migrated from github.com)
Copy Link

I should build this on 7.x-3.x-dev, oops.

I should build this on 7.x-3.x-dev, oops.
mattbk commented 2019-10-04 21:15:29 -05:00 (Migrated from github.com)
Copy Link

Add documentation to that function and test on site again.

Add documentation to that function and test on site again.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin add-metadata-endracing-7.x-3.1:add-metadata-endracing-7.x-3.1
git checkout add-metadata-endracing-7.x-3.1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matt
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matt/uc_stripe#10
No description provided.
Delete Branch "add-metadata-endracing-7.x-3.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?