Fix timezone handling #46

2018-11-19T20:58:47-06:00

mattbk commented

2018-11-19 20:58:47 -06:00

(Migrated from github.com)

Datetimes were being stored as local rather than UTC. I have fixed this so far, which means in the local db I am using there is a big jump between 2018-11-19 20:46:02 and 2018-11-20 02:47:02, where the former is in America/Chicago and the latter is in UTC.

Also fixed so far is the graph showing the wrong datetimes on the x-axis even though they are correct in the range picker.

set default timezone somewhere. Browser timestamp isn't set until a radio button is pressed, which is not good. See images below.
(local) fix earlier db entries

Datetimes were being stored as local rather than UTC. I have fixed this so far, which means in the local db I am using there is a big jump between 2018-11-19 20:46:02 and 2018-11-20 02:47:02, where the former is in America/Chicago and the latter is in UTC. Also fixed so far is the graph showing the wrong datetimes on the x-axis even though they are correct in the range picker. - [ ] set default timezone somewhere. Browser timestamp isn't set until a radio button is pressed, which is not good. See images below. - [ ] (local) fix earlier db entries <img width="945" alt="screen_shot_2018-11-19_at_8_59_39_pm-2" src="https://user-images.githubusercontent.com/3729038/48748993-6f0c3a80-ec3e-11e8-8753-1397f97fb70e.png"> <img width="956" alt="screen_shot_2018-11-19_at_8_59_57_pm" src="https://user-images.githubusercontent.com/3729038/48748996-73385800-ec3e-11e8-9002-deb98dd0f833.png">

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin fix-tz:fix-tz

git checkout fix-tz

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: matt/pi-temp#46