Large images don't show up on small screens #21

Closed
opened 2015-11-01 20:05:57 -06:00 by mattbk · 3 comments
mattbk commented 2015-11-01 20:05:57 -06:00 (Migrated from github.com)

Javascript issue?

Javascript issue?
mattbk commented 2015-11-02 11:18:42 -06:00 (Migrated from github.com)

I'm not sure if it's screen size, either. The aspect ratio seems to be fixed, so tall images are cut off. Defined by the first image?

I'm not sure if it's screen size, either. The aspect ratio seems to be fixed, so tall images are cut off. Defined by the first image?
mattbk commented 2015-11-02 11:30:59 -06:00 (Migrated from github.com)

It was a css thing, the image sizes were defined and overflow hidden. Also, setting the image background to the same as the page background eliminates extra gray box that shows up below images that are not the same height as the viewport.

It was a css thing, the image sizes were defined and overflow hidden. Also, setting the image background to the same as the page background eliminates extra gray box that shows up below images that are not the same height as the viewport.
mattbk commented 2015-11-02 11:45:13 -06:00 (Migrated from github.com)

No, we need to make sure the image fits into the window, this doesn't do it all the way. See phase 4.

Might be text getting in the way at the top.

No, we need to make sure the image fits into the window, this doesn't do it all the way. See phase 4. Might be text getting in the way at the top.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matt/changeblindness#21
No description provided.