matt/changeblindness
1
0
Fork 0
Code Issues 6 Pull Requests Packages Projects Releases Wiki Activity

Rethinking results table structure

Browse Source 
See comments in file.
This commit is contained in:
mattbk
2015-10-30 16:09:45 -05:00
parent ab3a6763c0
commit 06407aa707
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
index.php
View File

@ -78,6 +78,7 @@ switch ($mode) {
case 'finish': case 'finish':
$template = 'finish.html.twig'; $template = 'finish.html.twig';
// Store the result. // Store the result.
// This section will be removed
$query = $db->prepare('insert into vcd_results values (null, unix_timestamp(), ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)'); $query = $db->prepare('insert into vcd_results values (null, unix_timestamp(), ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)');
$query->bind_param( $query->bind_param(
'siiiiiiiii', 'siiiiiiiii',
@ -94,14 +95,19 @@ switch ($mode) {
) or die('Could not prepare query'); ) or die('Could not prepare query');
$query->execute() or die('Could not execute query:<br>'.mysqli_error($db)); $query->execute() or die('Could not execute query:<br>'.mysqli_error($db));
$query->close(); $query->close();
// End remove section
//Store the result.
//Loop through $results better //Loop through $results better
//This is not done yet, but shows an example of a loop you could put a query statement in. //This will allow running only one query rather than several: http://stackoverflow.com/a/10054657/2152245
//I think this will allow running only one query rather than several: http://stackoverflow.com/a/10054657/2152245
//However, if you want to define the number of phases/scenes in settings.json only (and not in a db setup script), //However, if you want to define the number of phases/scenes in settings.json only (and not in a db setup script),
// you have to use an EVA table here with fields like userid, phase, measure [xccordinate, ycoordinate, or responsetime], value [value for measure] at minimum. // you have to use an EAV table here with fields like userid, phase, measure [xccordinate, ycoordinate, or responsetime], value [value for measure] at minimum.
// then need to rewrite the query to pull them out of the db correctly, since each userid will have one row per measure per phase. // then need to rewrite the query to pull them out of the db correctly, since each userid will have one row per measure per phase.
//Criticism of EAV: https://www.simple-talk.com/sql/database-administration/five-simple--database-design-errors-you-should-avoid/,
//
//Below needs to be rewritten; because I have `phase` as a field, I can also have `xcoordinate`, `ycoordinate`, and `responsetime`
// as values as well. Table should have a field list of: uid, datetime, host, userid, phase, xcoordinate, ycoordinate, responsetime.
// SELECT query should then return one row per userid per phase/scene.
foreach ($_SESSION['results'] as $phasename => $phasevalue) { foreach ($_SESSION['results'] as $phasename => $phasevalue) {
foreach ($phasevalue as $measure => $measurevalue) { foreach ($phasevalue as $measure => $measurevalue) {
//Building an INSERT query: //Building an INSERT query:
@ -127,12 +133,9 @@ switch ($mode) {
$db->query($sql) or die('Could not execute query:<br>'.mysqli_error($db)); $db->query($sql) or die('Could not execute query:<br>'.mysqli_error($db));
} }
} }
//Debugging I think?
$variables['debug'] = $_SESSION['results'];
//Debugging
$variables['debug'] = $_SESSION['results'];
break; break;
case 'results': case 'results':
@ -155,11 +158,15 @@ switch ($mode) {
$template = 'results.html.twig'; $template = 'results.html.twig';
} }
// Only shows up when debug=true in settings.json.
if ($filtered) { if ($filtered) {
$variables['filtered'] = true; $variables['filtered'] = true;
$results = $db->query("select * from vcd_results where result_host != '192.168.0.1' order by result_date asc"); $results = $db->query("select * from vcd_results where result_host != '192.168.0.1' order by result_date asc");
} }
else { else {
//This query needs to be rewritten to use the results table (EAV version),
// but hopefully format the data in the same way (in the query itself, if possible?)
$results = $db->query("select * from vcd_results order by result_date asc"); $results = $db->query("select * from vcd_results order by result_date asc");
} }